Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent

[Nick Gasson]

On 04/27/20 18:35 pm, Jiri Olsa wrote:
>
> adding Stephane to the loop
>
> jirka
>
>> 
>> These three patches fix a couple of issues I ran into while using the
>> jitdump JVMTI agent to profile the SPECjbb benchmark.
>> 

Hi, any feedback on these patches?

Thanks,
Nick

>> 
>> 
>> Nick Gasson (3):
>>   perf jvmti: Fix jitdump for methods without debug info
>>   perf jvmti: Do not report error when missing debug information
>>   perf jvmti: Fix demangling Java symbols
>> 
>>  tools/perf/jvmti/libjvmti.c           | 24 +++++++--------
>>  tools/perf/tests/Build                |  1 +
>>  tools/perf/tests/builtin-test.c       |  4 +++
>>  tools/perf/tests/demangle-java-test.c | 42 +++++++++++++++++++++++++++
>>  tools/perf/tests/tests.h              |  1 +
>>  tools/perf/util/demangle-java.c       | 13 +++++----
>>  6 files changed, 66 insertions(+), 19 deletions(-)
>>  create mode 100644 tools/perf/tests/demangle-java-test.c
>> 
>> -- 
>> 2.26.1
>>