Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr

From: Joe Perches
Date: Thu May 14 2020 - 07:51:38 EST


On Thu, 2020-05-14 at 12:30 +0200, Christoph Hellwig wrote:
> On Wed, May 13, 2020 at 02:00:43PM -0700, Joe Perches wrote:
> > On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote:
> > > Add a helper to directly set the IP_RECVERR sockopt from kernel space
> > > without going through a fake uaccess.
> >
> > This seems used only with true as the second arg.
> > Is there reason to have that argument at all?
>
> Mostly to keep it symmetric with the sockopt. I could probably remove
> a few arguments in the series if we want to be strict.

My preference would use strict and add
arguments only when necessary.