Re: linux-next: build failure after merge of the keys tree

From: David Howells
Date: Thu May 14 2020 - 08:11:54 EST


Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:

> Your touch might be helpful here. CRYPTO_LIB_CHACHA20POLY1305 is a
> tristate and depends on as well as selects other things that are
> tristates.
>
> Meanwhile BIG_KEYS is a bool, which needs to select
> CRYPTO_LIB_CHACHA20POLY1305. However, it gets antsy if the the symbol
> its selecting has =m items in its hierarchy.
>
> Any suggestions? The ideal thing to happen would be that the select of
> CRYPTO_LIB_CHACHA20POLY1305 in BIG_KEYS causes all of the descendants
> to become =y too.

I think that select is broken in its behaviour - it doesn't propagate the
selection enforcement up the tree. You could try changing it to a depends on
or you could put in a select for every dependency. I'm not sure there are any
other options - unless we turn big_key into a module and institute autoloading
of keytypes on demand.

David