Re: [PATCH v10 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

From: Rob Herring
Date: Thu May 14 2020 - 10:54:38 EST


On Wed, May 06, 2020 at 03:04:20PM +0800, Xin Ji wrote:
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> for portable device. It converts MIPI to DisplayPort 1.3 4K.
>
> You can add support to your board with binding.

We have an example in the binding, no reason to also put in the commit
msg.

>
> Example:
> anx7625_bridge: encoder@58 {
> compatible = "analogix,anx7625";
> reg = <0x58>;
> status = "okay";
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
>
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> mipi2dp_bridge_in: port@0 {
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> };
> };
>
> mipi2dp_bridge_out: port@1 {
> reg = <1>;
> anx7625_out: endpoint {
> remote-endpoint = <&panel_in>;
> };
> };
> };
> };
>
> Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 98 ++++++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> new file mode 100644
> index 0000000..6e54176
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2019 Analogix Semiconductor, Inc.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> +
> +maintainers:
> + - Xin Ji <xji@xxxxxxxxxxxxxxxx>
> +
> +description: |
> + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> + designed for portable devices.
> +
> +properties:
> + "#address-cells": true
> + "#size-cells": true

These don't belong here.

> +
> + compatible:
> + items:
> + - const: analogix,anx7625
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: used for interrupt pin B8.
> + maxItems: 1
> +
> + enable-gpios:
> + description: used for power on chip control, POWER_EN pin D2.
> + maxItems: 1
> +
> + reset-gpios:
> + description: used for reset chip control, RESET_N pin B7.
> + maxItems: 1
> +
> + ports:
> + type: object
> +
> + properties:
> + port@0:
> + type: object
> + description:
> + Video port for MIPI DSI input.
> +
> + port@1:
> + type: object
> + description:
> + Video port for panel or connector.
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + anx7625_bridge: encoder@58 {

Drop any unused labels.

> + compatible = "analogix,anx7625";
> + reg = <0x58>;
> + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi2dp_bridge_in: port@0 {
> + reg = <0>;
> + anx7625_in: endpoint {
> + remote-endpoint = <&mipi_dsi>;
> + };
> + };
> +
> + mipi2dp_bridge_out: port@1 {
> + reg = <1>;
> + anx7625_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> + };
> + };
> --
> 2.7.4
>