RE: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

[Christian Herber]

Hi Andrew,

> On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote:
>> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote:
>>  ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active.
>>
>>      The TJA1102 is able to detect it if partner link is master.
>>
> master is not a cable diagnostics issue. This is a configuration
> issue.

Master is very relevant for cable diagnostics, as a cable measurement should not be done with an active link partner on the other end (i.e. a PHY in master mode trying to train the link).

So if the measurement detects an active link partner disturbing the measurement, it is important to report this to the user.

Christian