Re: [PATCH v3 00/15] mediatek: add support for MediaTek Ethernet MAC

From: David Miller
Date: Thu May 14 2020 - 15:56:07 EST


From: Bartosz Golaszewski <brgl@xxxxxxxx>
Date: Thu, 14 May 2020 09:59:27 +0200

> Next we do some cleanup of the mediatek ethernet drivers directory and update
> the devres documentation with existing networking devres helpers.

I don't agree with the new devres stuff.

You have to be very careful with the ordering of when you map/unmap
registers, free up anciliary resources, etc. in relationship to when
the netdev unregister happens.

Please submit this driver without these controversial devres changes,
and then you can submit and discuss those changes separately later.

Thanks.