Re: [PATCH 1/4] ipv6: lift copy_from_user out of ipv6_route_ioctl

From: David Miller
Date: Thu May 14 2020 - 20:51:25 EST


From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 14 May 2020 16:45:32 +0200

> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -542,19 +542,23 @@ int inet6_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
> {
> struct sock *sk = sock->sk;
> struct net *net = sock_net(sk);
> + void __user *argp = (void __user *)arg;

Please retain the reverse christmas tree ordering here.