Re: [PATCH v2 1/2] dt-bindings: usb: Add TI tps6598x device tree binding documentation

[Rob Herring]

On Thu, May 07, 2020 at 10:47:32PM +0100, Bryan O'Donoghue wrote:
> Add device tree binding documentation for the Texas Instruments tps6598x
> Type-C chip driver.
> 
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/ti,tps6598x.yaml  | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> new file mode 100644
> index 000000000000..8eaf4b6c4735
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/ti,tps6598x.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Texas Instruments 6598x Type-C Port Switch and Power Delivery controller DT bindings
> +
> +maintainers:
> +  - Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> +
> +description: |
> +  Texas Instruments 6598x Type-C Port Switch and Power Delivery controller
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tps6598x
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - const: irq
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c0 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        tps6598x: tps6598x@38 {
> +            compatible = "ti,tps6598x";
> +            reg = <0x38>;
> +
> +            interrupt-parent = <&msmgpio>;
> +            interrupts = <107 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-names = "irq";
> +
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&typec_pins>;
> +
> +            typec_con: connector {
> +                compatible = "usb-c-connector";
> +                label = "USB-C";
> +                port {

The connector binding has specific numbering of the ports defined for 
HS, SS, alt mode.

So you should have 'ports' here.

> +                    typec_ep: endpoint {
> +                        remote-endpoint = <&otg_ep>;
> +                    };
> +                };
> +            };
> +        };
> +    };
> +...
> -- 
> 2.25.1
>