Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

From: Viresh Kumar
Date: Thu May 14 2020 - 23:57:19 EST


On Fri, 15 May 2020 at 02:33, Georgi Djakov <georgi.djakov@xxxxxxxxxx> wrote:

> ---8<---
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 206caa0ea1c6..6661788b1a76 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> depends on ARCH_QCOM || COMPILE_TEST
> depends on EXTCON || !EXTCON
> + depends on INTERCONNECT || !INTERCONNECT

Again, as I said yesterday. This looks incorrect and may not fix the problem..

With this we will be able to select USB_DWC3_QCOM even when INTERCONNECT=m.

What we perhaps need here is:
depends on INTERCONNECT != m

--
viresh