Re: [PATCH v7 01/12] dt-bindings: add img,pvrsgx.yaml for Imagination GPUs
From: H. Nikolaus Schaller
Date: Fri May 15 2020 - 04:00:04 EST
> Am 05.05.2020 um 17:53 schrieb Rob Herring <robh@xxxxxxxxxx>:
>
> On Fri, Apr 24, 2020 at 10:34:04PM +0200, H. Nikolaus Schaller wrote:
>> The Imagination PVR/SGX GPU is part of several SoC from
>> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo,
>> Allwinner A83 and others.
>>
>> With this binding, we describe how the SGX processor is
>> interfaced to the SoC (registers and interrupt).
>>
>> The interface also consists of clocks, reset, power but
>> information from data sheets is vague and some SoC integrators
>> (TI) deciced to use a PRCM wrapper (ti,sysc) which does
>> all clock, reset and power-management through registers
>> outside of the sgx register block.
>>
>> Therefore all these properties are optional.
>>
>> Tested by make dt_binding_check
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/gpu/img,pvrsgx.yaml | 150 ++++++++++++++++++
>> 1 file changed, 150 insertions(+)
>> + oneOf:
>> + - description: SGX530-121 based SoC
>> + items:
>> + - enum:
>> + - ti,omap3-sgx530-121 # BeagleBoard A/B/C, OpenPandora 600MHz and similar
>
> Should be indented 2 more here and elsewhere where you have a list
> under a list.
added for patch v8 series.
BR and thanks,
Nikolaus