Re: stable/linux-4.4.y bisection: baseline.login on at91-sama5d4_xplained

From: Henri Rosten
Date: Fri May 15 2020 - 04:14:07 EST


On Tue, May 12, 2020 at 05:15:19PM -0400, Sasha Levin wrote:
> On Tue, May 12, 2020 at 01:29:06PM -0700, Florian Fainelli wrote:
> >
> >
> > On 5/12/2020 4:10 AM, Alexandre Belloni wrote:
> > > Hi,
> > >
> > > On 12/05/2020 06:54:29+0100, Guillaume Tucker wrote:
> > > > Please see the bisection report below about a boot failure.
> > > >
> > > > Reports aren't automatically sent to the public while we're
> > > > trialing new bisection features on kernelci.org but this one
> > > > looks valid.
> > > >
> > > > It appears to be due to the fact that the network interface is
> > > > failing to get brought up:
> > > >
> > > > [ 114.385000] Waiting up to 10 more seconds for network.
> > > > [ 124.355000] Sending DHCP requests ...#
> > > > ..#
> > > > .#
> > > > timed out!
> > > > [ 212.355000] IP-Config: Reopening network devices...
> > > > [ 212.365000] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> > > > #
> > > >
> > > >
> > > > I guess the board would boot fine without network if it didn't
> > > > have ip=dhcp in the command line, so it's not strictly a kernel
> > > > boot failure but still an ethernet issue.
> > > >
> > >
> > > I think the resolution of this issue is
> > > 99f81afc139c6edd14d77a91ee91685a414a1c66. If this is taken, then I think
> > > f5aba91d7f186cba84af966a741a0346de603cd4 should also be backported.
> >
> > Agreed.
>
> Okay, I've queued both for 4.4, thanks!

I notice 99f81afc139c was reverted in mainline with commit b43bd72835a5.
The revert commit points out that:

"It was papering over the real problem, which is fixed by commit
f555f34fdc58 ("net: phy: fix auto-negotiation stall due to unavailable
interrupt")"

Maybe f555f34fdc58 should be backported to 4.4 instead of 99f81afc139c?

Thanks,
-- Henri