Re: [PATCH v1] arm64: dts: qcom: apq8016-sbc-d3: Add Qualcomm APQ8016 SBC + D3 mezzanine

[Robert Foss]

On Thu, 14 May 2020 at 19:22, Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> On 22-04-20, 13:10, Robert Foss wrote:
> > Add device treee support for the Qualcomm APQ8016 SBC, otherwise known as
> > the Dragonboard 410c with the D3 mezzanine expansion board.
> >
> > The D3 mezzanine ships in a kit with a OmniVision 5640 sensor module,
> > which is what this DT targets.
> >
> > Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile           |  1 +
> >  arch/arm64/boot/dts/qcom/apq8016-sbc-d3.dts | 45 +++++++++++++++++++++
> >  2 files changed, 46 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-d3.dts
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index cc103f7020fd..025362471929 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -1,5 +1,6 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >  dtb-$(CONFIG_ARCH_QCOM)      += apq8016-sbc.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += apq8016-sbc-d3.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += apq8096-db820c.dtb
> >  dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += ipq6018-cp01-c1.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-d3.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3.dts
> > new file mode 100644
> > index 000000000000..1b85adeeada1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-d3.dts
> > @@ -0,0 +1,45 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
>
> Dual BSD + GPL please

Thanks.

>
> > +/*
> > + * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>
> we are in 2020 now :)

Maybe I should fix that.
I'll change the name of the d3 mezzanine to d3camera as well.

>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "apq8016-sbc.dtsi"
> > +
> > +/ {
> > +     model = "Qualcomm Technologies, Inc. APQ 8016 SBC w/ D3 Mezzanine";
> > +     compatible = "qcom,apq8016-sbc", "qcom,apq8016", "qcom,sbc";
> > +};
> > +
> > +&cci_i2c0 {
> > +     /delete-node/ camera_rear@3b;
> > +
> > +     camera_rear@76 {
> > +             compatible = "ovti,ov5640";
> > +             reg = <0x76>;
> > +
> > +             enable-gpios = <&msmgpio 34 GPIO_ACTIVE_HIGH>;
> > +             reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&camera_rear_default>;
> > +
> > +             clocks = <&gcc GCC_CAMSS_MCLK0_CLK>;
> > +             clock-names = "xclk";
> > +             clock-frequency = <23880000>;
> > +
> > +             vdddo-supply = <&camera_vdddo_1v8>;
> > +             vdda-supply = <&camera_vdda_2v8>;
> > +             vddd-supply = <&camera_vddd_1v5>;
> > +
> > +             status = "ok";
> > +
> > +             port {
> > +                     ov5640_ep: endpoint {
> > +                             clock-lanes = <1>;
> > +                             data-lanes = <0 2>;
> > +                             remote-endpoint = <&csiphy0_ep>;
> > +                     };
> > +             };
> > +     };
> > +};
> > --
> > 2.25.1
>
> --
> ~Vinod