Re: [PATCH 2/3] mm/util.c: make vm_memory_committed() more accurate
From: Michal Hocko
Date: Fri May 15 2020 - 05:04:47 EST
On Fri 15-05-20 16:11:09, Feng Tang wrote:
> On Fri, May 15, 2020 at 03:23:07PM +0800, Michal Hocko wrote:
> > On Fri 08-05-20 15:25:16, Feng Tang wrote:
> > > percpu_counter_sum_positive() will provide more accurate info.
> >
> > Why do we need that?
>
> This is a preparation for patch 3/3, which will enlarge the batch size
> of percpu-counter 'vm_committed_as'. Andi Kleen concerned that may
> hurt the accuracy for those readers (currently only /proc/meminfo
> and hyperV balloon drivers for status check)
>
> As in worst case, the deviation could be 'batch * nr_cpus', and
> with patch 3/3, that could be totalram_pages/16.
This information belongs to the changelog.
--
Michal Hocko
SUSE Labs