Re: [PATCH v2 0/3] printk: replace ringbuffer
From: Sergey Senozhatsky
Date: Fri May 15 2020 - 06:24:32 EST
On (20/05/01 11:46), John Ogness wrote:
> Hello,
>
> Here is a v2 for the first series to rework the printk subsystem. The
> v1 and history are here [0]. This first series only replaces the
> existing ringbuffer implementation. No locking is removed. No
> semantics/behavior of printk are changed.
>
> The VMCOREINFO is updated. RFC patches for the external tools
> crash(8) [1] and makedumpfile(8) [2] have been submitted that allow
> the new ringbuffer to be correctly read.
>
> This series is in line with the agreements [3] made at the meeting
> during LPC2019 in Lisbon, with 1 exception: support for dictionaries
> will not be discontinued [4]. Dictionaries are stored in a separate
> buffer so that they cannot interfere with the human-readable buffer.
I'm willing to bless this. The code looks good to me, nice job guys.
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
-ss