Re: [PATCH 5.7-rc5] HID: apple: Swap the Fn and Left Control keys on Apple keyboards

[Jiri Kosina]

On Fri, 15 May 2020, free5lot wrote:

> This patch allows users to swap the Fn and left Control keys on all Apple
> keyboards: internal (e.g. Macbooks) and external (both wired and wireless).
> The patch adds a new hid-apple module param: swap_fn_leftctrl (off by
> default).
> 
> Signed-off-by: Zakhar Semenov <mail@xxxxxxxxxxxx>
> ---
> This patch was created to eliminate the inconvenience of having an unusual
> order of 4 left-bottom keys on Apple keyboards for GNU+Linux users.
> Now it's possible to swap the Fn and left Control keys on Macbooks and
> external Apple keyboards and have the same experience as on usual PC layout.
> 
> The patch has been heavily tested for about 5 years by community at:
> https://github.com/free5lot/hid-apple-patched
> The patch is small and straightforward. The modified version of hid-apple
> is currently mentioned in wiki-documentation of several major GNU/Linux
> distributions (e.g. Ubuntu, Arch, openSUSE).

Hi,

thanks for sending the patch.

The one in this mail was whitespace-corrupted by your mail client, but the 
one you attached to the other mail was fine, so I've used that.

> --- hid-apple.c.orig	2020-05-12 11:06:26.000000000 +0300
> +++ hid-apple.c	2020-05-15 20:00:00.000000000 +0300

For any next submissions, pelase send the patch in -p ab format and with 
full path in the kernel tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs