Re: [PATCH v2 02/19] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

From: Andy Shevchenko
Date: Fri May 15 2020 - 08:37:14 EST


On Fri, May 15, 2020 at 01:18:15PM +0100, Mark Brown wrote:
> On Fri, May 15, 2020 at 03:01:11PM +0300, Andy Shevchenko wrote:
>
> > General question, doesn't spi core provides us some helpers like
> > spi_delay_exec()?
>
> Well, nobody wrote one.

spi_delay_exec() seems quite good to be used here.
Can we use it for delays?

> It's also a bit tricky to handle given that
> often you're checking some controller specific things while a FIFO in
> the IP drains/fills, though nothing insurmountable.

Yes, input can be gathered by reading controller specific data.

--
With Best Regards,
Andy Shevchenko