Re: [PATCH 1/3] serdev: ttyport: add devt for tty port

From: Greg KH
Date: Fri May 15 2020 - 08:46:25 EST


On Wed, May 06, 2020 at 03:23:12PM +0800, Claire Chang wrote:
> serial_match_port() uses devt to match devices. However, when serdev
> registers a tty port, devt has never been set. This makes
> device_find_child() always return NULL.
>
> Assign devt in serdev_tty_port_register() to fix this.
>
> Signed-off-by: Claire Chang <tientzu@xxxxxxxxxxxx>
> ---
> drivers/tty/serdev/serdev-ttyport.c | 2 ++
> 1 file changed, 2 insertions(+)

So is existing code broken because of this? Or does no one ever call
device_find_child() on this? Who needs/uses this?

thanks,

greg k-h