Re: [PATCH] Staging: rtl8723bs: os_de: if-else coding style issues

From: Dan Carpenter
Date: Fri May 15 2020 - 09:34:50 EST


On Fri, May 15, 2020 at 01:49:30PM +0100, John Oldman wrote:
> @@ -1167,9 +1166,8 @@ void rtw_dev_unload(struct adapter *padapter)
> DBG_871X_LEVEL(_drv_always_, "%s: driver in IPS-FWLPS\n", __func__);
> pdbgpriv->dbg_dev_unload_inIPS_cnt++;
> LeaveAllPowerSaveMode(padapter);
> - } else {
> + } else
> DBG_871X_LEVEL(_drv_always_, "%s: driver not in IPS\n", __func__);
> - }

You didn't run checkpatch on this patch. The rule is that if one side
of the if else statement has curly braces then all sides get curly
braces even if they're just one line long.

regards,
dan carpenter