Re: [PATCH v1 0/4] Optimize fw_devlink parsing

From: Greg Kroah-Hartman
Date: Fri May 15 2020 - 10:36:26 EST


On Fri, May 15, 2020 at 01:52:37AM -0700, Saravana Kannan wrote:
> On Thu, May 14, 2020 at 10:35 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> >
> > When fw_devlink is enabled on hardware with a large number of device
> > tree nodes, the initial device addition done in
> > of_platform_default_populate_init() can be very inefficient. This is
> > because most devices will fail to find all their suppliers when they are
> > added and will keep trying to parse their device tree nodes and link to
> > any newly added devices
> >
> > This was an item on my TODO list that I'm finally getting around to. On
> > hardware I'm testing on, this saved 1.216 _seconds_!
>
> Correction. It went from 1.216 _seconds_ to 61 _milliseconds_! So
> about 95% reduction in time.

Nice speedups! All now queued up, thanks.

greg k-h