Re: [PATCH 2/7] KVM: SVM: extract load_nested_vmcb_control

From: Paolo Bonzini
Date: Fri May 15 2020 - 19:34:59 EST


On 16/05/20 01:09, Krish Sadhukhan wrote:
>>
>> Â }
>> Â +static void load_nested_vmcb_control(struct vcpu_svm *svm, struct
>> vmcb *nested_vmcb)
>
>
> This function only separates a subset of the controls. If the purpose of
> the function is to separate only the controls that are related to
> migration, should it be called something like
> load_nested_state_vmcb_control or something like that ?

This function loads into svm->nested. The others are loaded into
svm->vmcb. They will be moved to this function later in the series,
when we add fields to svm->nested for all the controls that have to be
serialized in KVM_GET/SET_NESTED_STATE.

Paolo