Re: [PATCH v5 4/6] partitions/efi: Support GPT entry lookup at a non-standard location

[Randy Dunlap]

On 5/16/20 8:36 AM, Dmitry Osipenko wrote:
> diff --git a/block/partitions/efi.c b/block/partitions/efi.c
> index b64bfdd4326c..3af4660bc11f 100644
> --- a/block/partitions/efi.c
> +++ b/block/partitions/efi.c
> @@ -621,6 +621,14 @@ static int find_valid_gpt(struct parsed_partitions *state, gpt_header **gpt,
>          if (!good_agpt && force_gpt)
>                  good_agpt = is_gpt_valid(state, lastlba, &agpt, &aptes);
>  
> +	/* The force_gpt_sector is used by NVIDIA Tegra partition parser in
> +	 * order to convey a non-standard location of the GPT entry for lookup.
> +	 * By default force_gpt_sector is set to 0 and has no effect.
> +	 */

Please fix the multi-line comment format as described in
Documentation/process/coding-style.rst.

> +	if (!good_agpt && force_gpt && state->force_gpt_sector)
> +		good_agpt = is_gpt_valid(state, state->force_gpt_sector,
> +					 &agpt, &aptes);
> +
>          /* The obviously unsuccessful case */
>          if (!good_pgpt && !good_agpt)
>                  goto fail;

thanks.
-- 
~Randy