Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA

[Reinette Chatre]

Hi Babu,

On 5/14/2020 12:04 PM, Babu Moger wrote:
> 
> 
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@xxxxxxxxx>
>> Sent: Wednesday, May 6, 2020 6:50 PM
>> To: tglx@xxxxxxxxxxxxx; fenghua.yu@xxxxxxxxx; bp@xxxxxxxxx;
>> tony.luck@xxxxxxxxx
>> Cc: kuo-lang.tseng@xxxxxxxxx; ravi.v.shankar@xxxxxxxxx; mingo@xxxxxxxxxx;
>> Moger, Babu <Babu.Moger@xxxxxxx>; hpa@xxxxxxxxx; x86@xxxxxxxxxx;
>> linux-kernel@xxxxxxxxxxxxxxx; Reinette Chatre <reinette.chatre@xxxxxxxxx>
>> Subject: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA
>>
>> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>>

...

>>  static int rdt_thread_throttle_mode_show(struct kernfs_open_file *of,
>>  					 struct seq_file *seq, void *v)
>>  {
>>  	unsigned int throttle_mode = 0;
>>
>> +	if (boot_cpu_has(X86_FEATURE_PER_THREAD_MBA)) {
>> +		seq_puts(seq, "per-thread\n");
>> +
> You probably don't need an extra line here.
> 

This area looks slightly different after moving to a resource property
but unnecessary extra lines will be removed.

Thank you very much

Reinette