Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung_task.c

From: Kees Cook
Date: Sat May 16 2020 - 22:43:21 EST


On Sat, May 16, 2020 at 04:55:14PM +0800, Xiaoming Ni wrote:
> +/*
> + * This is needed for proc_doulongvec_minmax of sysctl_hung_task_timeout_secs
> + * and hung_task_check_interval_secs
> + */
> +static unsigned long hung_task_timeout_max = (LONG_MAX / HZ);

Please make this const. With that done, yes, looks great!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook