Re: [PATCH] csky: Fixup calltrace panic
From: Guenter Roeck
Date: Sun May 17 2020 - 13:52:25 EST
Hi,
On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote:
> The implementation of show_stack will panic with wrong fp:
>
> addr = *fp++;
>
> because the fp isn't checked properly.
>
> The current implementations of show_stack, wchan and stack_trace
> haven't been designed properly, so just deprecate them.
>
> This patch is a reference to riscv's way, all codes are modified from
> arm's. The patch is passed with:
>
> - cat /proc/<pid>/stack
> - cat /proc/<pid>/wchan
> - echo c > /proc/sysrq-trigger
>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
This patch results in:
gcc version: csky-linux-gcc (GCC) 9.3.0
Building csky:defconfig ... failed
--------------
Error log:
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/empty.o] Error 1
make[1]: *** [prepare0] Error 2
make: *** [sub-make] Error 2
when trying to build csky images with upstream gcc 9.3.0.
What version of gcc is needed to build csky images ? Also, would it be
possible to support the upstream version of gcc ?
Thanks,
Guenter