Re: [PATCH] net: bmac: Fix stack corruption panic in bmac_probe()

[Jeremy Kerr]

Hi Finn,

> This fixes an old bug recently revealed by CONFIG_STACKPROTECTOR.

Good catch. I'm not sure about the fix though. That variable ('addr')
should be a ethernet hardware address; I'm surprised we're accessing
past the 6th byte. The culprit seems to be this, where 'ea' is the
address buffer:

   static void
   bmac_get_station_address(struct net_device *dev, unsigned char *ea)
   {
        int i;
        unsigned short data;

        for (i = 0; i < 6; i++)
                {
                        reset_and_select_srom(dev);
                        data = read_srom(dev, i + EnetAddressOffset/2, SROMAddressBits);
                        ea[2*i]   = bitrev8(data & 0x0ff);
                        ea[2*i+1] = bitrev8((data >> 8) & 0x0ff);
                }
   }

- where it looks like the condition on that for-loop is wrong; we're
reading two bytes at a time there.

Can you try the attached patch?

Ben/Paul - any thoughts?

Cheers,


Jeremy

-----