Re: [PATCH 0/2] Expose KVM API to Linux Kernel

From: Thomas Gleixner
Date: Mon May 18 2020 - 05:38:48 EST


Anastassios Nanos <ananos@xxxxxxxxxxxxxxx> writes:
> On Mon, May 18, 2020 at 11:43 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>>
>> And this shows clearly how simple the user space is which is required to
>> do that. So why on earth would we want to have all of that in the
>> kernel?
>>
> well, the main idea is that all this functionality is already in the
> kernel. My view is that kvmmtest is as simple as kvmtest.

That still does not explain the purpose, the advantage and any reason
why this should be moreged.

> Moreover, it doesn't involve *any* mode switch at all while printing
> out the result of the addition of these two registers -- which I guess
> for a simple use-case like this it isn't much. But if we were to
> scale this to a large number of exits (and their respective handling
> in user-space) that would incur significant overhead. Don't you agree?

No. I still do not see the real world use case you are trying to
solve. We are not going to accept changes like this which have no proper
justification, real world use cases and proper numbers backing it up.

Thanks,

tglx