Re: [PATCH] powerpc/sysdev: fix compile errors

[Christophe Leroy]

Le 18/05/2020 Ã 12:32, Jiri Kosina a ÃcritÂ:
> On Mon, 18 May 2020, Jiri Kosina wrote:
>
> > > > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
> > > > implicit-declaration compile errors when building Cache-Sram.
> > > >
> > > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
> > > > âinstantiate_cache_sramâ:
> > > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
> > > > of function âioremap_coherentâ; did you mean âbitmap_complementâ?
> > > > [-Werror=implicit-function-declaration]
> > > >     cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > > >                             ^~~~~~~~~~~~~~~~
> > > >                             bitmap_complement
> > > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
> > > > pointer from integer without a cast [-Werror=int-conversion]
> > > >     cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > > >                           ^
> > > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
> > > > of function âiounmapâ; did you mean âroundupâ?
> > > > [-Werror=implicit-function-declaration]
> > > >     iounmap(cache_sram->base_virt);
> > > >     ^~~~~~~
> > > >     roundup
> > > > cc1: all warnings being treated as errors
> > > >
> > > > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> > > > Signed-off-by: WANG Wenhu <wenhu.wang@xxxxxxxx>
> > >
> > > Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx>
> >
> > As this doesn't seem to have been picked up for linux-next yet, I am
> > picking it up now.
>
> Only now I've noticed that this is actually a dead code o_O as this file
> can't be built by any combination of config options. So I am dropping the
> patch again, but why do we keep it in the tree in the first place?

There is a series aiming at making use of it, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421

Christophe