Re: [PATCH] blkcg: Fix memory leak in blkg_conf_prep()

[Wu Bo]

On 2020/5/15 23:08, Markus Elfring wrote:
> â
> > new_blkg = blkg_alloc(pos, q, GFP_KERNEL);
> â
>
> I suggest to omit the source code quotation from the change description.
>
>
> > if calling blkg_lookup_check() failed, at the IS_ERR block,
> > the new_blkg should be free before goto lable fail_unlock
> > in blkg_conf_prep() function.
>
> How do you think about a wording variant like the following?
>
>    If a call of the function âblkg_lookup_checkâ failed,
>    release the previously allocated block group before jumping
>    to the target âfail_unlockâ in the implementation of
>    the function âblkg_conf_prepâ.

Thanks for your suggestion. omit the source code quotation from the 
description is more friendly. I will modify the description in V2 patch.

Thanks,
Wu Bo

> Would you like to add the tag âFixesâ to the commit message?
>
> Regards,
> Markus