Re: [PATCH v2 18/20] mips: csrc-r4k: Decrease r4k-clocksource rating if CPU_FREQ enabled

[Serge Semin]

On Fri, May 15, 2020 at 11:06:47PM +0200, Thomas Bogendoerfer wrote:
> On Fri, May 15, 2020 at 10:48:27AM +0300, Serge Semin wrote:
> > Thomas,
> > Could you take a look at my comment below so I could proceed with the
> > patchset v3 development?
> 
> I can't help, but using r4k clocksource with changing frequency is
> probaly only usefull as a random generator. So IMHO the only two
> options are disabling it or implement what arch/x86/kernel/tsc.c does.
> 
> Thomas.

Thomas, could you proceed with the rest of the patches review?
ââ>[PATCH v2 16/20] bus: cdmm: Add MIPS R5 arch support
ââ>[PATCH v2 15/20] mips: cdmm: Add mti,mips-cdmm dtb node support
ââ>[PATCH v2 13/20] mips: early_printk_8250: Use offset-sized IO-mem accessors
ââ>[PATCH v2 12/20] mips: MAAR: Add XPA mode support
ââ>[PATCH v2 10/20] mips: Add CONFIG/CONFIG6/Cause reg fields macro
ââ>[PATCH v2 09/20] mips: Add CP0 Write Merge config support

It would be great if I fixed more comments in the next patchset version.

-Sergey

> 
> -- 
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]