Re: [PATCH net-next] net: phy: simplify phy_link_change arguments
From: David Miller
Date: Mon May 18 2020 - 19:54:23 EST
From: Doug Berger <opendmb@xxxxxxxxx>
Date: Mon, 18 May 2020 15:23:59 -0700
> This function was introduced to allow for different handling of
> link up and link down events particularly with regard to the
> netif_carrier. The third argument do_carrier allowed the flag to
> be left unchanged.
>
> Since then the phylink has introduced an implementation that
> completely ignores the third parameter since it never wants to
> change the flag and the phylib always sets the third parameter
> to true so the flag is always changed.
>
> Therefore the third argument (i.e. do_carrier) is no longer
> necessary and can be removed. This also means that the phylib
> phy_link_down() function no longer needs its second argument.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
Looks good, applied, thanks.