[PATCH] drm/msm/a6xx: don't try to set GPU frequency when GMU is suspended
From: Jonathan Marek
Date: Mon May 18 2020 - 23:09:03 EST
This fixes changing the frequency in sysfs while suspended, for example
when doing something like this:
cat devfreq/3d00000.gpu/max_freq > devfreq/3d00000.gpu/min_freq
Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index aec54cde8534..9498803dcad9 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -151,13 +151,20 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu, unsigned long freq)
break;
gmu->current_perf_index = perf_index;
+ gmu->freq = gmu->gpu_freqs[perf_index];
+
+ /*
+ * devfreq may try to change frequency target even when suspended
+ * this can happen when changing frequency through sysfs
+ * don't try to set freq when suspended, it will be set on resume
+ */
+ if (!pm_runtime_active(gmu->dev))
+ return;
if (gmu->legacy)
__a6xx_gmu_set_freq(gmu, perf_index);
else
a6xx_hfi_set_freq(gmu, perf_index);
-
- gmu->freq = gmu->gpu_freqs[perf_index];
}
unsigned long a6xx_gmu_get_freq(struct msm_gpu *gpu)
--
2.26.1