Re: [PATCH 2/3] arm64: dts: qcom: Add initial sm6125 SoC support

From: Bjorn Andersson
Date: Tue May 19 2020 - 02:10:18 EST

On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote:

> Initial support for SM6125 SoC. CPUs, fixed clocks,
> interrupt controller, and UART.
>
> This DTSI is ported from the forked vendor version from
> XiaoMi which can be found at [0]. It seems internally
> this board is referred to as "Trinket".
>
> Since GCC isn't upstreamed yet, we use dummy clocks for GENI.
>
> [0]: https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/willow-p-oss/arch/arm64/boot/dts/qcom/trinket.dtsi
>
> Signed-off-by: Eli Riggs <eli@xxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm6125.dtsi | 201 +++++++++++++++++++++++++++
> 1 file changed, 201 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm6125.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> new file mode 100644
> index 0000000000000..4931402d20c9d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -0,0 +1,201 @@
> +// SPDX-License-Identifier: GPL-2.0-only

Please use dual GPL/BSD license for dts files, if you can.

> +// Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
> +// Copyright (C) 2019 XiaoMi, Inc.
> +// Copyright (C) 2020 Eli Riggs <eli@xxxxxx>
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> + interrupt-parent = <&intc>;
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + chosen { };
> +
> + clocks {
> + xo_board: xo-board {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <19200000>;
> + clock-output-names = "xo_board";
> + };
> + sleep-clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32000>;
> + clock-output-names = "sleep_clk";
> + };
> + };
> +
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> + CPU0: cpu@100 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x100>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1638>;
> + d-cache-size = <0x10000>;
> + i-cache-size = <0x10000>;
> + };
> + CPU1: cpu@101 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x101>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1638>;
> + d-cache-size = <0x10000>;
> + i-cache-size = <0x10000>;
> + };
> + CPU2: cpu@102 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x102>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1638>;
> + d-cache-size = <0x10000>;
> + i-cache-size = <0x10000>;
> + };
> + CPU3: cpu@103 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x103>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1638>;
> + d-cache-size = <0x10000>;
> + i-cache-size = <0x10000>;
> + };
> + CPU4: cpu@0 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x0>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + d-cache-size = <0x8000>;
> + i-cache-size = <0x8000>;
> + };
> + CPU5: cpu@1 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x1>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + d-cache-size = <0x8000>;
> + i-cache-size = <0x8000>;
> + };
> + CPU6: cpu@2 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x2>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + d-cache-size = <0x8000>;
> + i-cache-size = <0x8000>;
> + };
> + CPU7: cpu@3 {
> + device_type = "cpu";
> + compatible = "qcom,kryo260";
> + reg = <0x0 0x3>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + d-cache-size = <0x8000>;
> + i-cache-size = <0x8000>;
> + };
> + cpu-map {
> + cluster0 {
> + core0 {
> + cpu = <&CPU4>;
> + };
> + core1 {
> + cpu = <&CPU5>;
> + };
> + core2 {
> + cpu = <&CPU6>;
> + };
> + core3 {
> + cpu = <&CPU7>;
> + };
> + };
> + cluster1 {
> + core0 {
> + cpu = <&CPU0>;
> + };
> + core1 {
> + cpu = <&CPU1>;
> + };
> + core2 {
> + cpu = <&CPU2>;
> + };
> + core3 {
> + cpu = <&CPU3>;
> + };
> + };
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + /* We expect the bootloader to fill this in */
> + reg = <0 0 0 0>;
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
> + clock-frequency = <19200000>;
> + };
> +
> + soc: soc {
> + #address-cells = <1>;
> + #size-cells = <1>;

In order to describe the dma-ranges properly the address-cells needs to
be 2, so please make both of these 2 from the start.

> + ranges = <0 0 0 0xffffffff>;
> + compatible = "simple-bus";
> +
> + intc: interrupt-controller@f200000 {
> + compatible = "arm,gic-v3";
> + reg = <0xf200000 0x10000>, /* GICD */
> + <0xf300000 0x100000>; /* GICR * 8 */

Please pad addresses to 8 digits and please sort nodes under /soc by
address.

> + #interrupt-cells = <3>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + interrupt-controller;
> + #redistributor-regions = <1>;
> + redistributor-stride = <0x0 0x20000>;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + /* This GENI and its children actually use GCC clocks,
> + * but the bootloader has already set them up for us.
> + * xo_board is used as a dummy here so the driver doesn't
> + * give up.
> + */

Given that you won't get very far without GCC and e.g. pinctrl driver I
would prefer to see some patches for those as well, to ensure that this
will be able to go beyond basic UART.

Regards,
Bjorn

> + qupv3_0: geniqup@4ac0000 {
> + compatible = "qcom,geni-se-qup";
> + reg = <0x4ac0000 0x2000>;
> + clock-names = "m-ahb", "s-ahb";
> + clocks = <&xo_board>, <&xo_board>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + qupv3_se4_2uart: serial@4a90000 {
> + compatible = "qcom,geni-debug-uart";
> + reg = <0x4a90000 0x4000>;
> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "se";
> + clocks = <&xo_board>;
> + };
> + };
> + };
> +};
> --
> 2.20.1
>