Re: [PATCH V1 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules
From: Vaibhav Agarwal
Date: Tue May 19 2020 - 03:53:58 EST
On Sun, May 17, 2020 at 07:37:06PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 17/05/2020 22:47:20+0530, Vaibhav Agarwal wrote:
> > Greybus Codec driver allows modules to be dynamically added and removed,
> > which further requires updating the DAPM configurations as well.
> >
> > With current snd_soc architecture, dynamic audio modules is not yet
> > supported. This patch provides helper APIs to update DAPM configurations
> > in response to modules which are dynamically added or removed. The
> > source is primarily based on snd_dapm.c
> >
>
> I really think you should send this patch series to the ASoC
> maintainers, especially this patch. The main goal shouldn't be to simply
> fix compilation issues but to try to get the driver out of staging else,
> the current situation will happen again.
Agree Alexandre. I'll share this with ASoC maintainers as well.
Also, I'm seeking opinion regarding the scope of pushing GB Audio out of
staging tree. I'm keen to make the relevant changes and work actively
for the same. However, I don't have a real device to test the latest
code and thus not sure if the changes can be pushed to sound soc tree.
GB maintainers, kindly share your opinion.
--
Regards,
Vaibhav