Re: [PATCH 2/2] clk: sprd: return correct type of value for _sprd_pll_recalc_rate
From: Baolin Wang
Date: Tue May 19 2020 - 09:13:16 EST
On Tue, May 19, 2020 at 11:00 AM Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote:
>
> From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
>
> The function _sprd_pll_recalc_rate() defines return value to unsigned
> long, but it would return a negative value when malloc fail, changing
> to return its parent_rate makes more sense, since if the callback
> .recalc_rate() is not set, the framework returns the parent_rate as
> well.
>
> Fixes: 3e37b005580b ("clk: sprd: add adjustable pll support")
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
Looks good to me.
Reviewed-by: Baolin Wang <baolin.wang7@xxxxxxxxx>
--
Baolin Wang