Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

From: Andrew Lunn
Date: Tue May 19 2020 - 15:03:26 EST


On Tue, May 19, 2020 at 01:59:16PM -0500, Dan Murphy wrote:
> Jakub
>
> On 5/19/20 1:48 PM, Jakub Kicinski wrote:
> > On Tue, 19 May 2020 13:41:40 -0500 Dan Murphy wrote:
> > > > Is this now a standard GCC warning? Or have you turned on extra
> > > > checking?
> > > I still was not able to reproduce this warning with gcc-9.2.  I would
> > > like to know the same
> > W=1 + gcc-10 here, also curious to know which one of the two makes
> > the difference :)
>
> W=1 made the difference I got the warning with gcc-9.2

I wonder if we should turn on this specific warning by default in
drivers/net/phy? I keep making the same mistake, and it would be nice
if GCC actually told me.

Andrew