Re: [PATCH] arm64: dts: imx8mm: Add node for SPDIF

[Shawn Guo]

On Sat, May 02, 2020 at 08:20:11AM -0500, Adam Ford wrote:
> The i.MX8M Mini can support SPIDF which is very similar to the
> IP used on the i.MX35.
> 
> This patch adds the SPIF node.
> 
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index d46e727fc362..00aad55ece65 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -358,6 +358,29 @@ micfil: micfil@30080000 {
>  				status = "disabled";
>  			};
>  
> +			spdif1: spdif@30090000 {

It should be in a patch series with previous micfil one, as it cannot be
applied independently.

> +				compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif";
> +				reg = <0x30090000 0x10000>;
> +				interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX8MM_CLK_AUDIO_AHB>, /* core */
> +					 <&clk IMX8MM_CLK_24M>, /* rxtx0 */
> +					 <&clk IMX8MM_CLK_SPDIF1>, /* rxtx1 */
> +					 <&clk IMX8MM_CLK_DUMMY>, /* rxtx2 */
> +					 <&clk IMX8MM_CLK_DUMMY>, /* rxtx3 */
> +					 <&clk IMX8MM_CLK_DUMMY>, /* rxtx4 */
> +					 <&clk IMX8MM_CLK_AUDIO_AHB>, /* rxtx5 */
> +					 <&clk IMX8MM_CLK_DUMMY>, /* rxtx6 */
> +					 <&clk IMX8MM_CLK_DUMMY>, /* rxtx7 */
> +					 <&clk IMX8MM_CLK_DUMMY>; /* spba */
> +				clock-names = "core", "rxtx0",
> +					      "rxtx1", "rxtx2",
> +					      "rxtx3", "rxtx4",
> +					      "rxtx5", "rxtx6",
> +					      "rxtx7", "spba";
> +				dmas = <&sdma2 28 18 0>, <&sdma2 29 18 0>;
> +				dma-names = "rx", "tx";
> +				status = "disabled";
> +			};

Have a newline between nodes.

Shawn

>  			gpio1: gpio@30200000 {
>  				compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio";
>  				reg = <0x30200000 0x10000>;
> -- 
> 2.25.1
>