Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

[Dan Murphy]

Florian

On 5/20/20 12:45 PM, Florian Fainelli wrote:
> On 5/20/2020 10:20 AM, Dan Murphy wrote:
> > Andrew/Florian
> >
> > On 5/20/20 11:43 AM, Andrew Lunn wrote:
> > > > I am interested in knowing where that is documented. I want to RTM I
> > > > grepped for a few different words but came up empty
> > > Hi Dan
> > >
> > > It probably is not well documented, but one example would be
> > >
> > > Documentation/devicetree/bindings/net/ethernet-controller.yaml
> > >
> > > says:
> > >
> > >  ÂÂÂÂÂÂ # RX and TX delays are added by the MAC when required
> > >  ÂÂÂÂÂÂ - rgmii
> > >
> > >  ÂÂÂÂÂÂ # RGMII with internal RX and TX delays provided by the PHY,
> > >  ÂÂÂÂÂÂ # the MAC should not add the RX or TX delays in this case
> > >  ÂÂÂÂÂÂ - rgmii-id
> > >
> > >  ÂÂÂÂÂÂ # RGMII with internal RX delay provided by the PHY, the MAC
> > >  ÂÂÂÂÂÂ # should not add an RX delay in this case
> > >  ÂÂÂÂÂÂ - rgmii-rxid
> > >
> > >  ÂÂÂÂÂÂ # RGMII with internal TX delay provided by the PHY, the MAC
> > >  ÂÂÂÂÂÂ # should not add an TX delay in this case
> > >
> > >  ÂÂÂÂÂÂ Andrew
> > OKI I read that. I also looked at a couple other drivers too.
> >
> > I am wondering if rx-internal-delay and tx-internal-delay should become
> > a common property like tx/rx fifo-depth
> > > And properly document how to use it or at least the expectation on use.
> Yes they should, and they should have an unit associated with the name.


UGH I think I just got volunteered to do make them common.

Dan