Re: [PATCH 7/8] virt: vbox: Log unknown ioctl requests as error

[Arnd Bergmann]

On Wed, May 20, 2020 at 9:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Every now and then upstream adds new ioctls without notifying us,
> log unknown ioctl requests as an error to catch these.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/virt/vboxguest/vboxguest_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> index ffd76b949276..e0e343d0ba93 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1739,7 +1739,7 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
>                 return vbg_ioctl_log(data);
>         }
>
> -       vbg_debug("VGDrvCommonIoCtl: Unknown req %#08x\n", req);
> +       vbg_err("Userspace made an unknown ioctl req %#08x\n", req);

I think these should be ratelimited to avoid spamming the console with
too many messages for something that can be trivially triggered from
user space.

       Arnd