RE: [PATCH v1 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2 voltage range

[Robin Gong]

2020/05/21 14:02 Peng Fan <peng.fan@xxxxxxx> wrote:
> > Subject: [PATCH v1 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2
> > voltage range
> >
> > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low
> > group
> > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage
> > groups have been supported at bd718x7-regulator driver, hence, just
> > corrrect the voltage range to 1.6v~3.3v. For ldo2@xxxx, correct voltage range
> too.
> > Otherwise, ldo1 would be kept @3.0v and ldo2@xxxx which violate
> > i.mx8mm datasheet as the below warning log in kernel:
> >
> > [    0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> > [    0.999196] LDO2: Bringing 800000uV into 900000-900000uV
> >
> > Signed-off-by: Robin Gong <yibin.gong@xxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 4 ++--
> >  arch/arm64/boot/dts/freescale/imx8mn-evk.dts      | 9 +++++++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > index d07e0e6..a1e5483 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > @@ -113,7 +113,7 @@
> >
> >  			ldo1_reg: LDO1 {
> >  				regulator-name = "LDO1";
> > -				regulator-min-microvolt = <3000000>;
> > +				regulator-min-microvolt = <1600000>;
> >  				regulator-max-microvolt = <3300000>;
> >  				regulator-boot-on;
> >  				regulator-always-on;
> > @@ -121,7 +121,7 @@
> >
> >  			ldo2_reg: LDO2 {
> >  				regulator-name = "LDO2";
> > -				regulator-min-microvolt = <900000>;
> > +				regulator-min-microvolt = <800000>;
> >  				regulator-max-microvolt = <900000>;
> >  				regulator-boot-on;
> >  				regulator-always-on;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > index 61f3519..117ff4b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > @@ -13,6 +13,15 @@
> >  	compatible = "fsl,imx8mn-evk", "fsl,imx8mn";  };
> >
> > +&ecspi1 {
> > +	status = "okay";
> > +spidev0: spi@0 {
> > +	compatible = "ge,achc";
> > +	reg = <0>;
> > +	spi-max-frequency = <1000000>;
> > +	};
> > +};
> > +
> 
> This was added by mistake?
Sorry, will send out v2.