Re: [PATCH v2] arm: dts: am33xx-bone-common: add gpio-line-names

From: Drew Fustini
Date: Thu May 21 2020 - 15:23:46 EST


On Thu, May 21, 2020 at 08:26:42PM +0300, Grygorii Strashko wrote:
>
>
> On 21/05/2020 17:41, Robert Nelson wrote:
> > > Not sure if it should be in am335x-bone-common.dtsi.
> > >
> > > For example:
> > > am335x-boneblack.dts
> > > #include "am335x-bone-common.dtsi"
> > > #include "am335x-boneblack-common.dtsi" <-- hdmi defined only here
> >
> > Ah crap, yeah that's a good point.. So if we stick it in...
> > am335x-boneblack-common.dtsi
> >
> > Then the Black-Wireless now has Ethernet...
> >
> > am335x-boneblack-wireless.dts
> > #include "am335x-bone-common.dtsi"
> > #include "am335x-boneblack-common.dtsi"
> >
> > It's going to be ugly, copy and paste mess, but i guess we might as
> > well stick it in the device " am335x-boneblack.dts"?
>
> Seems like.
>
> Unfortunately, there is no way to partially overwrite "gpio-line-names"
> property.
>
> --
> Best regards,
> grygorii

Thank you for pointing out that those gpio-line-names are really
specific to the BeagleBone Black and not applicable for other boards
like the BeagleBone Green which lack eMMC.

I will post a new patch for am335x-boneblack.dts.

After that is reviewed and applied, I will then create patches for the
the other BeagleBone models.

thanks,
drew