Re: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release()

From: Markus Elfring
Date: Fri May 22 2020 - 05:09:25 EST


> This is caused by dereferencing 'rpmb' after put_device().

I suggest to improve also this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151

How do you think about a wording variant like the following?

The data structure member ârpmb->mdâ was passed to a call of
the function âmmc_blk_putâ after a call of the function âput_deviceâ.
Reorder these function calls to keep the data accesses consistent.


Would you like to add the tag âFixesâ to the commit message?

Regards,
Markus