Re: [PATCH V4 5/5] iio: adc: Clean up ADC code common to PMIC5 and PMIC7

From: Jishnu Prakash
Date: Fri May 22 2020 - 07:59:27 EST


Hi Andy,

On 5/13/2020 3:21 PM, Andy Shevchenko wrote:
On Wed, May 13, 2020 at 12:24 PM Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote:
This commit includes the following changes:
Add a common function used for read_raw callback for
both PMIC5 and PMIC7 ADCs.
Add exit function for ADC.
Add info_property under adc_data to more efficiently
distinguish PMIC5 and PMIC7 ADCs.
Something happened to the editor settings. We have lines up to 72
(recommended) characters.
In this case, I just meant to put each change on a different line. I'll fix it in the next post.

...

@@ -512,6 +518,7 @@ static int adc5_read_raw(struct iio_dev *indio_dev,
&adc5_prescale_ratios[prop->prescale],
adc->data,
adc_code_volt, val);
+
if (ret)
return ret;

Unrelated.
I'll remove it in the next post.