Re: [PATCH v2] i2c: cadence: Add an error handling for platform_get_irq()

[Wolfram Sang]

> The change is valid but the question is if make sense to do it in this
> way. Some drivers are using devm_request_irq to do do job.
> 
> For example:
>  	id->irq = platform_get_irq(pdev, 0);
>         ret = devm_request_irq(&pdev->dev, id->irq, cdns_i2c_isr, 0,
>                                   DRIVER_NAME, id);
>         if (ret)
> 		return ret;

I like this version better. Maybe we should simply move the
platform_get_irq() line to the devm_request_irq() call?

Attachment: signature.asc
Description: PGP signature