Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend

[Grygorii Strashko]

On 22/05/2020 19:50, Suman Anna wrote:
> On 5/22/20 11:39 AM, Grygorii Strashko wrote:
> > vlan_for_each() are required to be called with rtnl_lock taken, otherwise
> > ASSERT_RTNL() warning will be triggered - which happens now during System
> > resume from suspend:
> > ÂÂ cpsw_suspend()
> > ÂÂ |- cpsw_ndo_stop()
> > ÂÂÂÂ |- __hw_addr_ref_unsync_dev()
> > ÂÂÂÂÂÂ |- cpsw_purge_all_mc()
> > ÂÂÂÂÂÂÂÂÂ |- vlan_for_each()
> > ÂÂÂÂÂÂÂÂÂÂÂÂ |- ASSERT_RTNL();
> >
> > Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.
> >
> > Fixes: 15180eca569b net: ethernet: ti: cpsw: fix vlan mcast
>
> Format for this should be
> Fixes: 15180eca569b ("net: ethernet: ti: cpsw: fix vlan mcast")

Right sorry

> regards
> Suman
>
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> > ---
> > Â drivers/net/ethernet/ti/cpsw.c | 4 ++++
> > Â 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> > index c2c5bf87da01..ffeb8633e530 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -1753,11 +1753,15 @@ static int cpsw_suspend(struct device *dev)
> > ÂÂÂÂÂ struct cpsw_common *cpsw = dev_get_drvdata(dev);
> > ÂÂÂÂÂ int i;
> > +ÂÂÂ rtnl_lock();
> > +
> > ÂÂÂÂÂ for (i = 0; i < cpsw->data.slaves; i++)
> > ÂÂÂÂÂÂÂÂÂ if (cpsw->slaves[i].ndev)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ if (netif_running(cpsw->slaves[i].ndev))
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ cpsw_ndo_stop(cpsw->slaves[i].ndev);
> > +ÂÂÂ rtnl_unlock();
> > +
> > ÂÂÂÂÂ /* Select sleep pin state */
> > ÂÂÂÂÂ pinctrl_pm_select_sleep_state(dev);

--
Best regards,
grygorii