Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

[Alex Deucher]

On Fri, May 22, 2020 at 1:46 PM Gustavo A. R. Silva
<gustavoars@xxxxxxxxxx> wrote:
>
> On Wed, May 20, 2020 at 09:42:27AM +0200, Christian KÃnig wrote:
> > >
> > > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> >
> > Acked-by: Christian KÃnig <christian.koenig@xxxxxxx>
> >
> > May I suggest that we add a section how to correctly do this to
> > Documentation/process/coding-style.rst or similar document?
> >
>
> That's already on my list. :)
>
> > I've seen a bunch of different approaches and some even doesn't work with
> > some gcc versions and result in a broken binary.
> >
>
> Do you have an example of that one that doesn't work with some GCC
> versions? It'd be interesting to take a look...

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/radeon/radeon_atombios.c?id=a7ee824a6255e347ea76e2f00827e81bbe01004e

Alex

>
> Thanks
> --
> Gustavo
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx