Re: [PATCH v5] arch/x86: Update config and kernel doc for MPK feature on AMD

[Borislav Petkov]

On Wed, May 13, 2020 at 05:39:12PM -0500, Babu Moger wrote:
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1197b5596d5a..6b7303ccc1dd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1887,10 +1887,10 @@ config X86_UMIP
>  	  results are dummy.
>  
>  config X86_INTEL_MEMORY_PROTECTION_KEYS
> -	prompt "Intel Memory Protection Keys"
> +	prompt "Memory Protection Keys"
>  	def_bool y
>  	# Note: only available in 64-bit mode
> -	depends on CPU_SUP_INTEL && X86_64
> +	depends on X86_64 && (CPU_SUP_INTEL || CPU_SUP_AMD)
>  	select ARCH_USES_HIGH_VMA_FLAGS
>  	select ARCH_HAS_PKEYS
>  	---help---
> @@ -1902,6 +1902,13 @@ config X86_INTEL_MEMORY_PROTECTION_KEYS
>  
>  	  If unsure, say y.
>  
> +config X86_MEMORY_PROTECTION_KEYS
> +	# Set the "INTEL_"-free option whenever the "INTEL_" one is set.
> +	# The "INTEL_" one should be removed and replaced by this option
> +	# after 5.10. This avoids exposing most 'oldconfig' users to this
> +	# churn.
> +	def_bool X86_INTEL_MEMORY_PROTECTION_KEYS

I only picked up the discussion from the sidelines but why do we need
this at all? If we don't want to have churn, then we can leave it be
called X86_INTEL_MEMORY_PROTECTION_KEYS, not change the manpage and
have this depend on CPU_SUP_AMD too so that people can select it on AMD
machines, and get on with our lives.

So what's up?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette