Re: [PATCH 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()

[Markus Elfring]

> The system will crash when we insmod crypto/tcrypt.ko whit mode=38.

* I suggest to use the word âwithâ in this sentence.

* Will it be helpful to explain the passed mode number?


> BTW I add a check for sg_nents_for_len() its return value since
> sg_nents_for_len() function could fail.

Please reconsider also development consequences for this suggestion.
Will a separate update step be more appropriate for the addition of
an input parameter validation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n138

Would you like to add the tag âFixesâ to the commit message?

Regards,
Markus