Re: [PATCH] media: smiapp: Fix runtime PM imbalance on error

[Sakari Ailus]

Hi Dinghao,

Thanks for the patch.

On Fri, May 22, 2020 at 05:03:13PM +0800, Dinghao Liu wrote:
> When v4l2_async_register_subdev_sensor_common() returns
> an error code, a pairing runtime PM usage counter
> decrement is needed to keep the counter balanced.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
>  drivers/media/i2c/smiapp/smiapp-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
> index 5e4f6a2ef78e..43ba63c48a87 100644
> --- a/drivers/media/i2c/smiapp/smiapp-core.c
> +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> @@ -3103,6 +3103,7 @@ static int smiapp_probe(struct i2c_client *client)
>  	return 0;
>  
>  out_disable_runtime_pm:
> +	pm_runtime_put_autosuspend(&client->dev);

Can you use pm_runtime_put_noidle(), as the device musn't be powered off
here yet?

>  	pm_runtime_disable(&client->dev);
>  
>  out_media_entity_cleanup:

-- 
Regards,

Sakari Ailus