Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support

From: Matt Jolly
Date: Mon May 25 2020 - 06:33:39 EST

On 25/5/20 7:39 pm, Johan Hovold wrote:
Hmm. I'd a call a build breakage a bit more than just a "typo" as it
indicates this patch was never tested at all before being submitted.
I applied, built, and tested it against the sources for the kernel I run on my machine, but made several silly mistakes: both manually applying the patch to my copy of the repo (which is not my running kernel), and not build testing that change before submission. Not good indeed.

I could definitely have been more descriptive in the change notes.

Consider me appropriately chastised!