Re: [PATCH -next] leds: blinkm: remove set but not used variable

[Pavel Machek]

On Sat 2020-05-09 22:23:57, Hongbo Yao wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/leds/leds-blinkm.c:483:6: warning: variable âretâ set
> but not used [-Wunused-but-set-variable]
>   int ret;

Should error be propagated?
								Pavel
								

> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Hongbo Yao <yaohongbo@xxxxxxxxxx>
> ---
>  drivers/leds/leds-blinkm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index e11fe1788242..a493ee0e0fc7 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -480,9 +480,8 @@ static int blinkm_led_blue_set(struct led_classdev *led_cdev,
>  
>  static void blinkm_init_hw(struct i2c_client *client)
>  {
> -	int ret;
> -	ret = blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> -	ret = blinkm_transfer_hw(client, BLM_GO_RGB);
> +	blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> +	blinkm_transfer_hw(client, BLM_GO_RGB);
>  }
>  
>  static int blinkm_test_run(struct i2c_client *client)

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature